Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KUBESAW-172: Restart host-operator at the end of the register-member command #90

Merged
merged 13 commits into from
Dec 23, 2024
Merged

KUBESAW-172: Restart host-operator at the end of the register-member command #90

merged 13 commits into from
Dec 23, 2024
+175 −67

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Dec 9, 2024 •
edited
Loading

This PR is to use the Restart command from Register-Member command and restart host operator

There Related PR in Toolchain-E2e

Toolchain-E2E : codeready-toolchain/toolchain-e2e#1080

@fbm3307 fbm3307 mentioned this pull request Dec 9, 2024
Merged
@fbm3307 fbm3307 marked this pull request as ready for review December 14, 2024 14:15
mfrancisc
mfrancisc reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job 👍

I have only few minor comments.

pkg/cmd/adm/register_member.go Outdated Show resolved Hide resolved
pkg/cmd/adm/register_member.go Outdated Show resolved Hide resolved
@fbm3307
rename to restartFunc in reg-mem
09ba7d7 
Signed-off-by: Feny Mehta <[email protected]>
@fbm3307
some changes
a56a109 
Signed-off-by: Feny Mehta <[email protected]>
@fbm3307
clean up
8c31569 
Signed-off-by: Feny Mehta <[email protected]>
mfrancisc
mfrancisc reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor things related to the tests

pkg/cmd/adm/register_member.go Outdated Show resolved Hide resolved
pkg/cmd/adm/unregister_member_test.go Outdated Show resolved Hide resolved
pkg/cmd/adm/unregister_member_test.go Outdated Show resolved Hide resolved
pkg/cmd/adm/unregister_member_test.go Show resolved Hide resolved
pkg/cmd/adm/unregister_member_test.go Outdated Show resolved Hide resolved
@fbm3307 fbm3307 requested a review from mfrancisc December 18, 2024 11:25
mfrancisc
mfrancisc approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job 👍

Thanks for addressing my comments.

MatousJobanek
MatousJobanek reviewed Dec 20, 2024
View reviewed changes
pkg/cmd/adm/register_member.go Outdated Show resolved Hide resolved
pkg/cmd/adm/register_member.go Outdated Show resolved Hide resolved
pkg/cmd/adm/register_member_test.go Show resolved Hide resolved
pkg/cmd/adm/register_member.go Outdated Show resolved Hide resolved
MatousJobanek
MatousJobanek approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@fbm3307 fbm3307 merged commit ec701fa into kubesaw:master Dec 23, 2024
6 of 7 checks passed
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (f99bb4a) to head (53aaed1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cmd/adm/register_member.go 31.57% 13 Missing ⚠️
pkg/cmd/adm/restart.go 52.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   68.02%   67.83%   -0.20%     
==========================================
  Files          44       44              
  Lines        3240     3264      +24     
==========================================
+ Hits         2204     2214      +10     
- Misses        841      853      +12     
- Partials      195      197       +2
Files with missing lines Coverage Δ
pkg/cmd/adm/unregister_member.go 54.54% <100.00%> (ø)
pkg/cmd/adm/restart.go 58.28% <52.00%> (+1.13%) ⬆️
pkg/cmd/adm/register_member.go 71.65% <31.57%> (-2.12%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@drpaneas drpaneas Awaiting requested review from drpaneas drpaneas is a code owner

@metlos metlos Awaiting requested review from metlos metlos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbm3307 @MatousJobanek @mfrancisc